-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asciidoctor compact theme and build script change #11
Conversation
👍 I'm a fan of the compact theme idea. I've used it in Brackets. This compact theme has got me especially excited thinking about combining this with PR #12 and #13 that make printing asciidoctor HTML more compelling. A shorter print version is a nice theme to have available. A couple things:
|
I'll be looking at this pull request during or shortly after getting 1.5.0 released. |
Leif, thanks for your comments. I applied the changes you suggested to the asciidoctor-compact theme. It's already part of the Brackets extension. I'll update the official Brackets plugin repository once the final 1.5 release of Asciidoctor is out. |
Now that 1.5.0 is out, I'll be sure to look into getting this merged soon. Great stuff! |
This is outdated as of 1.5.0. Just grab https://github.com/nerk/asciidoctor-stylesheet-factory/blob/master/sass/asciidoctor-compact.scss for an updated version. Currently, this is good enough for me for the brackets preview, but is a bit of a quick hack and could certainly use some tuning. Maybe some SASS control directives should be put into original asciidoctor.scss to allow for creating the original and compact styles from the same source? |
Also needed are appropriate settings, of course: https://github.com/nerk/asciidoctor-stylesheet-factory/blob/master/sass/settings/_asciidoctor-compact.scss |
I agree, compact should probably be a variation on the default theme so they stay in sync. |
@nerk , any chance to get this one merged? |
Unfortunately, I do not have enough skills regarding typography to make the compact style really good. @mojavelinux would certainly be the right person. The current stylesheet was more of a hack to make something work for the Brackets preview. |
This is completely outdated. In addition, the compact theme needs a lot of work before it is ready. |
This adds a compact version of the default Asciidoctor theme, 'asciidoctor-compact'. Smaller font and less spacing between elements.
The build script failed when invoked directly, because it used 'let' which is not known to '/bin/sh'.